bport added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:99
> I think this will be broken if you change this combo box, then change theme.
> 
> When a user explicitly changes this combo box this binding gets broken with 
> currentIndex now reflecting an explicit number.
> 
> On theme change cursorThemeSettings.cursorSize changes correctly but our 
> binding is gone.
> 
> This might have to be a connection again

After testing seems to be not broken.
the binding is set to a method that transorm current size value to index 
(kcm.cursorSizeIndex do that)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24519

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to