ngraham added a comment.
Almost done, just a tiny bit of polish is needed! See inline comments:
INLINE COMMENTS
> kcm.cpp:61
> KAboutData* about = new KAboutData(
> QStringLiteral("kcm_baloofile"), i18n("Configure File Search"),
> QStringLiteral("0.1"), QString(), KAboutLicense::GPL,
Make this match the name shown in the list ("File Search")
> main.qml:32
> +
> + KCM.ConfigModule.quickHelp: i18n("This module lets you configure the
> search in the system.")
> + ColumnLayout {
"This module lets you configure the file indexer and search functionality."
> main.qml:36
> + Layout.leftMargin: Kirigami.Units.smallSpacing * 2
> + Layout.rightMargin: Kirigami.Units.smallSpacing * 2
> +
This item isn't inside a Layout, so `Layout.<anything>` has no effect. You want
`anchors.<whatever>` instead.
Also the margins should be `Kirigami.Units.largeSpacing`.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D23718
To: tcanabrava, #plasma, mart, ngraham
Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n,
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
ahiemstra
