davidedmundson added inline comments.

INLINE COMMENTS

> server.h:49
> +     */
> +    Q_PROPERTY(bool inhibited READ inhibited WRITE setInhibited NOTIFY 
> inhibitedChanged)
> +

Having a property which doesn't read what you last wrote leads to very 
confusing QML. Sure you can make it work, but it won't be declarative.

What Server::Private has internally with the 3 inhibtedLocally, 
inhibitedExternally, and then the read-only effectiveInhibited value is a 
really neat and tidy design.

Can't we map that directly to the public API and properties here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24486

To: broulik, #plasma, dfaure
Cc: davidedmundson, dfaure, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to