apol added a comment.
  +1 otherwise

INLINE COMMENTS

> ActionToolBar.qml:126
>                      opacity: x + width <= parent.width
> -                    enabled: opacity
> +                    enabled: opacity && modelData.enabled
>  

I'd do the enabled && opacity, it feels very wrong using a real number as a 
boolean >.<.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_enable

REVISION DETAIL
  https://phabricator.kde.org/D24498

To: ahiemstra, #kirigami, ngraham
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
davidedmundson, mart, hein

Reply via email to