broulik added inline comments.
INLINE COMMENTS
> main.qml:80
> + var found = false;
> + for(var v in modeOptions) {
> + if (modeOptions[v] === kcm.plasmaFeedbackLevel) {
Use `Array.findIndex`
> main.qml:91
>
> - onActivated: {
> - kcm.plasmaFeedbackLevel = modeOptions.get(index).value;
> + onValueChanged: {
> + kcm.plasmaFeedbackLevel = modeOptions[value]
Use `onMoved` which is the slider equivalent to `onActivated`
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D24470
To: apol, #plasma, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
