ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  So this patch adds a semi-hidden menu item on the About page that opens the 
User Feedback KCM in a KCMShell window. I think this needs a better UX:
  
  1. We finally need a real Settings page/window for Discover if we're going to 
be adding more user-configurable settings like this one. The About page isn't 
an appropriate place for this. Maybe we should Change Sources to Settings and 
add it there.
  2. Shouldn't the UI here be Discover-specific? The global KCM doesn't seem 
relevant since it talks about turning on or off telemetry for all KDE apps and 
allows configuring stuff for Plasma specifically. Strictly speaking, Discover 
isn't a part of Plasma. And from a user perspective, Discover is just an app 
among other apps.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5961

To: apol, #plasma, vkrause, ngraham
Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

Reply via email to