ngraham added inline comments.

INLINE COMMENTS

> davidre wrote in Comparison.qml:66
> I use it for centering the icon in the middle of the 128x128 free space for 
> the icon. `Qt.AlignCenter` is not enough for that. In the first version of 
> the diff I tried make up for that with setting of top and bottom margins 
> depending on the text height and icon size but that was to complicated and 
> also didn't produce the correct result I think.

There is no `Qt.AlignCenter` (though there should be IMO); I think you need to 
do `Qt.AlignHCenter | Qt.AligtVCenter`

REPOSITORY
  R118 Plasma SDK

BRANCH
  comparison (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24305

To: davidre, #plasma, #vdg, ngraham
Cc: ngraham, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to