broulik added inline comments.

INLINE COMMENTS

> fvogt wrote in action_popup.js:217
> Does this also hit all the frames inside?

Effectively, yes. It asks the extension.js whether it knows any players on the 
given tab, which will include all frames, see the actual implementation of 
"hasTabPlayer" which checks `playerIds` containing all of them.
(Also, I tested with an embedded YouTube player iframe which showed up 
alongside the main page)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24194

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to