broulik added inline comments.

INLINE COMMENTS

> batterymonitor.qml:56
> +        if (powermanagementDisabled) {
> +            return i18n("Battery and Brightness")
> +        }

You can probably just return `plasmoid.title` in the default case.
Also, what's the reason for not showing percentage when power management is 
disabled? This isn't about the service not running or being a desktop PC, this 
is true when screens are forced on.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to