broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY The notification popup typically gets in the way of the system tray popup. In case it would cover a Plasma dialog, hide the notification popup. It doesn't specifically check for System Tray but then it will also get out of the way of your calendar and other widgets you might have placed in the respective corner. TEST PLAN Both genius and evil. Still surprised by how little code it is, especially that on QML side a simple binding is enough. The change from `var` to `let` is for sane scoping, so that the `dialog` we refer to is correct one, with `var` scoping it would always be the one from the last iteration of the loop F7426329: ba96db11-fd22-4bb0-b1ef-f042fa3557b3.mp4 <https://phabricator.kde.org/F7426329> Moving the systray popup with Alt+left click is just to demonstrate the dodging capabilities of the popup ;) - Opened calendar, popup hid - Also hides when an Alternatives dialog covers it - does not hide for panel controller - Closing notification and interacting with them, especially context menu (as it opens a new window) still works fine REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24208 AFFECTED FILES applets/notifications/CMakeLists.txt applets/notifications/notificationapplet.cpp applets/notifications/notificationapplet.h applets/notifications/package/contents/ui/global/Globals.qml To: broulik, #plasma, #vdg Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
