ngraham added inline comments.

INLINE COMMENTS

> romangg wrote in Panel.qml:77
> Options below does not only affect the currently shown output above but all 
> outputs in the current configuration. I don't think this is clear anymore 
> with only the horizontal line.

I think the fact that the slider's label says "Global scale" communicates that 
it's a global setting. As for the other control in this group, I think we can 
make it clearer with better wording.

> romangg wrote in Panel.qml:90
> This option does not only impact the currently shown output above but all 
> others as well. Therefore the plural displays/outputs would be more correct 
> than a singular "display".
> 
> Also a question is if we want to call it display, output, screen or monitor 
> in user facing texts and then do it everywhere like this. I assume there are 
> pros and cons for all of these nouns.

"Output" is a bit too technical I think, and"Monitor" doesn't cover the case of 
projectors. Personally I like "Display" but I'm open to being convinced 
otherwise.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D23798

To: ngraham, romangg, #vdg, #kwin
Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to