chrisx updated this revision to Diff 65769. chrisx set the repository for this revision to R111 KSysguard Library. chrisx added a comment.
@meven Sorry I've totally forgotten about your suggestions when I was updating the patch... I have renamed `DetailsDlg` to `ProcessDetailsDialog`. But I've got some minor issues with code indentation. I have tried out `uncrustify-kf5` (which didn't even work out-of-box. Instead of formatting the files in-place, it produced `*.uncrustify` files instead. I have uncrustify 0.69, and I worked around the issue by adding `--replace` to the arguments for uncrystify in `uncrustify-kf5`). But the script produces way too many changes in some files I changed. One of those files is `processes_linux_p.cpp`, which uses both spaces and tabs for indentation. So at this moment I've only committed some of the indentation changes. Any further help with pushing this patch forward would be greatly appreciated. REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12827?vs=65628&id=65769 REVISION DETAIL https://phabricator.kde.org/D12827 AFFECTED FILES lsofui/lsof.h processcore/process.cpp processcore/process.h processcore/processes_linux_p.cpp processui/CMakeLists.txt processui/ProcessDetailsDialog.cpp processui/ProcessDetailsDialog.h processui/ProcessDetailsDialogUI.ui processui/ksysguardprocesslist.cpp processui/ksysguardprocesslist.h To: chrisx, broulik, davidedmundson, mart Cc: meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
