meven accepted this revision. meven added a comment. This revision is now accepted and ready to land.
Seems good to me ! I am using this now, and it is great. But my review does not weight much as I am not a ksysguard maintainer/developer. It makes me want to add a network graph by process in ksysguard. INLINE COMMENTS > main.cpp:97 > + > + std::this_thread::sleep_for(std::chrono::seconds(1)); > + } Could the refresh rate be a parameter or at least a constant instead of an hardcoded value. REPOSITORY R106 KSysguard BRANCH network_plugin REVISION DETAIL https://phabricator.kde.org/D23342 To: ahiemstra, #plasma, meven Cc: meven, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
