ndavis added a comment.

  +1

INLINE COMMENTS

> module.cpp:39
>      KAboutData *aboutData = new KAboutData("kcm_pulseaudio",
> -                                           i18nc("@title", "Configure the 
> Audio Volume"),
> +                                           i18nc("@title", "Audio"),
>                                             global_s_versionStringFull,

Why are we changing the title to just "Audio"? Weren't we supposed to use 
descriptions for the page titles to make them useful? Am I mistaken?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  promote-audio-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23542

To: ngraham, #vdg, #plasma, drosca, nicolasfella, sitter
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to