jgrulich added a subscriber: mart.
jgrulich added a comment.

  Looks good to me, but I'm not the author of this code. I would rather let 
@mart to approve this review.

INLINE COMMENTS

> Applet.qml:71
> +    function removeSource(source1, friendlyName1, source2, friendlyName2) {
> +        var found = false;
> +        for (var i = 0; i < sourcesModel.count; ++i) {

This variable doesn't seem to be used.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21035

To: bernhardu, #plasma, jgrulich
Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to