----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3214/#review4429 -----------------------------------------------------------
Ship it! looks good; have tested it here as well and it's a nice improvement. i'll commit this for you shortly, though if you continue submitting patches (and i do hope you do :) then we'll want to get you an account of your own eventually :) /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunchApplet.cpp <http://reviewboard.kde.org/r/3214/#comment3918> should be '} else {' - Aaron On 2010-03-08 21:32:38, Ingomar Wesp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3214/ > ----------------------------------------------------------- > > (Updated 2010-03-08 21:32:38) > > > Review request for Plasma. > > > Summary > ------- > > This patch changes the computation of the insert position when dropping > something on the applet's layout (it does not address dropping to the dialog > yet). Additionally, appending items to the end of the list should be fixed > now (it lead to a crash previously). > > If I'm not mistaken, this should fix bugs #200798 and #225011. > > > This addresses bugs 200798 and 225011. > https://bugs.kde.org/show_bug.cgi?id=200798 > https://bugs.kde.org/show_bug.cgi?id=225011 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/generic/applets/quicklaunch/quicklaunchApplet.cpp > 1100817 > > Diff: http://reviewboard.kde.org/r/3214/diff > > > Testing > ------- > > > Thanks, > > Ingomar > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
