hpereiradacosta created this revision.
hpereiradacosta added reviewers: Breeze, ndavis.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hpereiradacosta requested review of this revision.

REVISION SUMMARY
  Following on https://phabricator.kde.org/D23169, it turns out one can 
simplify the toolbuttons with menu rendering strongly by rendering the whole 
frame at once, and removing the code for detecting the presence of the menu 
alltogether. This makes for cleaner code with no visual difference with respect 
to how it should look (and no 'double-shadow').

TEST PLAN
  F7264651: Screenshot_20190820_174107.png 
<https://phabricator.kde.org/F7264651>
  This is how toolbuttons with menu appear with this patch. (no change with 
respect to without)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D23296

AFFECTED FILES
  kstyle/breezestyle.cpp

To: hpereiradacosta, #breeze, ndavis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to