broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> logic.js:45
>      if (batteryData["Is Power Supply"] && batteryData["Capacity"] != "" && 
> typeof batteryData["Capacity"] == "number") {
> -        data.push({label: i18n("Capacity:") })
> -        data.push({value: i18nc("Placeholder is battery capacity", "%1%", 
> batteryData["Capacity"]) })
> +        data.push({label: i18n("Degradation:") })
> +        data.push({value: i18nc("Placeholder is battery capacity 
> degradation", "%1%", 100 - batteryData["Capacity"]) })

I think this needs some explanatory context

REPOSITORY
  R120 Plasma Workspace

BRANCH
  capacity-to-degradation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23271

To: ngraham, #vdg, broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

Reply via email to