meven added a comment.
In D22012#512025 <https://phabricator.kde.org/D22012#512025>, @davidedmundson wrote: > It was first added in 2d5f289767ee7b7c54f8b55e8032d20ef7f092f4 <https://phabricator.kde.org/R119:2d5f289767ee7b7c54f8b55e8032d20ef7f092f4> with some pretty sparse docs, then copy pasted all over the place. > > It does appear to be no longer needed. > > I suspect https://codereview.qt-project.org/c/qt/qtbase/+/139775 fixes it which was back in 5.6 > > If we remove here, please can we also do > > kcms/desktoptheme/kcm.cpp: qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings); > kcms/fonts/fonts.cpp: qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings); > kcms/lookandfeel/kcm.cpp: qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings); > > in p-d Will do. It is also present in other apps than kcms : $ rg AA_DontCreateNativeWidgetSiblings systemsettings/sidebar/SidebarMode.cpp 258: qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings); spectacle/src/Main.cpp 37: app.setAttribute(Qt::AA_DontCreateNativeWidgetSiblings, true); kdevelop/app/main.cpp 348: QCoreApplication::setAttribute(Qt::AA_DontCreateNativeWidgetSiblings); discover/discover/main.cpp 97: app.setAttribute(Qt::AA_DontCreateNativeWidgetSiblings); I wonder if this can be removed there as well. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D22012 To: meven, mart, #plasma, davidedmundson Cc: davidedmundson, ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
