ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS
> davidedmundson wrote in ConfigGeneral.qml:124
> What's this about? It's typically a sign that something else is wrong.
> 
> Probably the lack of spacer in this dialog means the label below occupies 
> quite large box that it's in the middle of.
> 
> Try aligning the label below to the top instead.

The reason is actually because of the weird way that the inline labels are 
positioned in `ConfigButtons` which causes the component to have no spacing 
above it, but extra spacing below it. Definitely open to fixing that, but I 
couldn't figure out how.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23158

To: ngraham, #vdg, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to