----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3165/ -----------------------------------------------------------
Review request for Plasma. Summary ------- The system tray behaves very erratically here, depending on exact circumstances (compositing or not, some apparently random factors) so I looked into the code a bit. First I removed a very ugly hack that apparently fixed a bug that could be fixed otherwise, this is why I'm posting this to reviewboard. That part is the last hunk. After doing that plasma-desktop crashed a lot, so I fixed the obviously dangerous (the way non-POD statics are) to outright incorrect (deleting and never recreating the background thingie) usage of class-statics, too. Diffs ----- trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp 1100150 Diff: http://reviewboard.kde.org/r/3165/diff Testing ------- Not much yet, less than an hour of use - no crashes so far. No erratic behavior either. Thanks, Andreas _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel