----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2939/ -----------------------------------------------------------
Review request for Plasma. Summary ------- Replaced the deprecated animation API (Plasma::Animator::self()->moveItem()) with PlasmaAnimator::SlideAnimation on the Fifteen Puzzle plasmoid animation. The Piece class had a change on its inheritance chain: QGraphicsWidget replaces multiple inheritance from QObject, QGraphicsItem (but that could later be changed to a Plasma::Widget inheritance). A QHash was needed because there are times that multiple animations are run at the same time, thus not allowing us to have a single weak pointer, but a weak pointer for every Piece item in the board. Diffs ----- trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1090523 trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1090523 trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1090523 trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1090523 Diff: http://reviewboard.kde.org/r/2939/diff Testing ------- After compile + install, the Fifteen puzzle animations when switching pieces from the board behaved the same way. Thanks, Bruno _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
