> On None, Enrico Ros wrote: > > plasma bouncing-ball cumulative fixes
sorry, I didn't mean to post this review, and I don't know how to delete it. - Enrico ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2779/#review4013 ----------------------------------------------------------- On 2010-02-01 19:13:09, Enrico Ros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2779/ > ----------------------------------------------------------- > > (Updated 2010-02-01 19:13:09) > > > Review request for Plasma. > > > Summary > ------- > > A comprehensive patch for the Bouncing Ball applet that fixes: > * framerate independent animation > * better coloriziation > * horizontal momentum lost (220809) > * audio-player on demand (off by default) > * scale invariant rotation > * optimized performance > * using less pointers > * commented and maintainable > * unbreak rotation display (a bug in 4.4) > * cleanup crazy indentation > > I'm sorry about the big changes but I found the code really not maintainable, > so now it's looking more similar to the other applets. > > This fixes bug 220809. > This contributes to fixing bug 216263 (by delaying the sound player > initialization, can't crash if no sound). > > My girlfriend thanks who will merge this patch ;-) > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/bball/CMakeLists.txt 1083550 > trunk/KDE/kdeplasma-addons/applets/bball/bball.h 1083550 > trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp 1083550 > > Diff: http://reviewboard.kde.org/r/2779/diff > > > Testing > ------- > > Compared to the previous bouncing ball there is a little different physics, > but in the end the user will be pleased of this working ball. > > > Thanks, > > Enrico > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
