-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2741/#review3923
-----------------------------------------------------------



/trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/scriptengine.cpp
<http://reviewboard.kde.org/r/2741/#comment3310>

    Per Sebastian:
    
    Shouldn't be necessary:
    
    "On failure, the fallback NullEngine (which does nothing and !isValid()) is
    returned."


- Wayne


On 2010-01-27 15:44:17, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2741/
> -----------------------------------------------------------
> 
> (Updated 2010-01-27 15:44:17)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> When creating scripts for plasma first init there is for the moment no way to 
> add the battery widget only if the machine have batteries. this patch try to 
> work on this issue.
> 
> With this function , haveBattery() return true if the machine have some.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/scriptengine.h 
> 1081032 
>   
> /trunk/KDE/kdebase/workspace/plasma/desktop/shell/scripting/scriptengine.cpp 
> 1081032 
> 
> Diff: http://reviewboard.kde.org/r/2741/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to