> On 2010-01-04 16:23:08, Marco Martin wrote: > > it's annoying that's an undocumented and totally weird behaviour, but if > > this is actually the case yeah, the patch is correct
Thanks to pinotree on #kde-devel, I got the explanation: QDBusAbstractAdaptor do not forward signals by default, but auto-generated adaptors do (that's the only code in the auto-generated constructor). Will commit the patch tomorrow then. - Aurélien ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2485/#review3569 ----------------------------------------------------------- On 2010-01-04 16:08:08, Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2485/ > ----------------------------------------------------------- > > (Updated 2010-01-04 16:08:08) > > > Review request for Plasma. > > > Summary > ------- > > When a notification with actions is shown, clicking an action button causes > the ActionInvoked (and NotificationClosed) signals to be emitted twice. See > this bug report: > https://bugs.edge.launchpad.net/ubuntu/+source/banshee/+bug/501677 > > It seems the QDBusAbstractAdaptor automatically forward signals, even if I > find no evidence of this in the source code. > > > Diffs > ----- > > > trunk/KDE/kdebase/workspace/plasma/generic/dataengines/notifications/notificationsengine.cpp > 1065171 > > Diff: http://reviewboard.kde.org/r/2485/diff > > > Testing > ------- > > - Monitor the signals with: dbus-monitor > "interface=org.freedesktop.Notifications,type=signal" > - Start an application which show a notification with actions. I used the > test-multi-actions.py example from python-notify. > - Click an action, notice both signals are listed twice. > - After the patch, signals are only listed once. > > > Thanks, > > Aurélien > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
