----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2391/#review3470 -----------------------------------------------------------
Ship it! apart a micostyle issu is good to go trunk/KDE/kdelibs/plasma/animator.h <http://reviewboard.kde.org/r/2391/#comment2778> the "on" prefix is not used is Qt and kde, just a scrollStatechanged should be ok - Marco On 2009-12-20 16:07:33, Bruno Abinader wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2391/ > ----------------------------------------------------------- > > (Updated 2009-12-20 16:07:33) > > > Review request for Plasma, Marco Martin, igorto, and Adenilson Cavalcanti. > > > Summary > ------- > > This patch forward the "stateChanged" signal emitted from the private kinetic > scroll animation all the way to Plasma::ScrollWidget, which then forwards > this signal to its childs. This enables an object which derives from > Plasma::ScrollWidget to know the kinetic scrolling animation state. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/animator.h 1064064 > trunk/KDE/kdelibs/plasma/deprecated/animator.cpp 1064064 > trunk/KDE/kdelibs/plasma/private/animator_p.h 1064064 > trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1064064 > trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1064064 > trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1064064 > trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1064064 > > Diff: http://reviewboard.kde.org/r/2391/diff > > > Testing > ------- > > Using a test plasmoid [1], after this patch it was able to do the following > call: > > if (m_scrollWidget->scrollingState() == QAbstractAnimation::Stopped) { > doSomething(); > } > > [1] > http://gitorious.org/contact-list-plasmoid-example/contact-list-plasmoid-example/commit/09fc6b8781d4d52a32f2f2e5c96fa2c6e904a8ea > > Notice that the other plasmoids won't be affected by this patch, since it > only adds a new method, not altering or removing the existent behaviour. > > > Thanks, > > Bruno > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
