----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2361/#review3404 -----------------------------------------------------------
A few comments: - keep the same string if you want to get this in 4.4 - remove the kDebug() line - If the user checks 'Do not show this message' then the message should not been shown again (see in Settings) - I expect a sound like a ring (quite intrusive) if I put a timer on as an option. With notification we had a sound but it was too tiny. Should be thought of for 4.5 Overall I think more work should be done in this timer for 4.5 (maybe a bit of usability study should be conducted): how do users expect to set the timer? couldn't some mouse scrolling set it? how do users expect to be notified of the elapsed time? sound, message, ... Should the timer stay at 00:00 or come back to last time set after finishing? - Anne-Marie On 2009-12-12 10:15:49, Sujith H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2361/ > ----------------------------------------------------------- > > (Updated 2009-12-12 10:15:49) > > > Review request for Plasma and Anne-Marie Mahfouf. > > > Summary > ------- > > Implementing a TODO in the timer.cpp. Removing the KNotification with > KMessageBox. > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1061089 > > Diff: http://reviewboard.kde.org/r/2361/diff > > > Testing > ------- > > Testing is done. > > > Thanks, > > Sujith > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
