-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2191/
-----------------------------------------------------------
(Updated 2009-11-25 05:30:03.553432)
Review request for Plasma.
Changes
-------
Diff updated. Includes:
* "Get New Widgets" button+submenu
* Changes by Petri Damstén ("get new widgets" button between the input field
and tabbar + close button)
* close button working
Summary
-------
"Add widgets" button in the new widgets explorer. There are points that need to
be defined, such as the button position / strings in the interface. In this
draft, a toolbutton and a kmenu are used like in the old explorer (Variable
names changed because IMHO the old ones weren't clear).
A known issue in the interface is the menu position: Although
corona->popupPosition returns a reasonable point, the menu appears on the top
of the screen - probably, my fault.
Suggestions and comments are welcome =)
This addresses bug 211576.
https://bugs.kde.org/show_bug.cgi?id=211576
Diffs (updated)
-----
/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletslist.cpp
1053621
/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.h
1053621
/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.cpp
1053621
/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletsfiltering.h
1053621
/trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletsfiltering.cpp
1053621
/trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.cpp
1053621
/trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.h 1053621
Diff: http://reviewboard.kde.org/r/2191/diff
Testing
-------
Adding widgets from GHNS works, Google Gadgets are installed but the widget
list isn't updated correctly. "From file" needs more tests.
Screenshots
-----------
Ger New Widgets button
http://reviewboard.kde.org/r/2191/s/267/
Menu
http://reviewboard.kde.org/r/2191/s/268/
Thanks,
Anselmo
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
