----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2259/#review3250 -----------------------------------------------------------
Ship it! - Aaron On 2009-11-21 18:20:59, Jacopo De Simoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2259/ > ----------------------------------------------------------- > > (Updated 2009-11-21 18:20:59) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > This patch adds action support to the default interface by adding a button > for each one of actionsForMatch given by the runnerManager. > Hovering (and focusing) over a button changes the subtext of the item > according to the selected action. > > The logic is all there, it has still some rough edges from the graphical side > (e.g. we should make sure that there are not "too many" displayed actions) > and focusing with the keyboard is missing (it should be done togheter with > the configuration button) but these can be fixed quite easily once it gets > committed. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.h 1052428 > trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp > 1052428 > trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultitem.h 1052428 > trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultitem.cpp > 1052428 > trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.h > 1052428 > trunk/KDE/kdebase/workspace/krunner/interfaces/default/resultscene.cpp > 1052428 > > Diff: http://reviewboard.kde.org/r/2259/diff > > > Testing > ------- > > the only runner supporting actions I am aware of is the Devices (solid) > runner (in kdereview); tested with that and it works. > > > Screenshots > ----------- > > Actions for the device runner > http://reviewboard.kde.org/r/2259/s/269/ > > > Thanks, > > Jacopo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
