----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2260/#review3248 -----------------------------------------------------------
Ship it! - Aaron On 2009-11-22 15:32:19, Jacopo De Simoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2260/ > ----------------------------------------------------------- > > (Updated 2009-11-22 15:32:19) > > > Review request for Plasma and Aaron Seigo. > > > Summary > ------- > > This patch adds removeMatch and removeMatches methods to RunnerContext; these > methods are needed to update results in krunner in case the runner knows that > something changed and the previously reported results are not valid anymore > (e.g. a window listed by the windows runner is closed [this currently leads > to a crash] or a device is removed / changed its state (solid runner), a file > has been deleted (places runner, nepomuk)) > > Both methods fire matchesChanged; in case the match is to be modified the > runner can exploit the event compression done by runnermanager by removing > the match and adding it back right away with the required modifications. > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/querymatch.h 1052445 > trunk/KDE/kdelibs/plasma/querymatch.cpp 1052445 > trunk/KDE/kdelibs/plasma/runnercontext.h 1052445 > trunk/KDE/kdelibs/plasma/runnercontext.cpp 1052445 > > Diff: http://reviewboard.kde.org/r/2260/diff > > > Testing > ------- > > tested (in PoC stage) with the solidrunner and it works > > > Thanks, > > Jacopo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
