----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2213/#review3195 -----------------------------------------------------------
Ship it! other than the one small comment about how to deal post-uninstall, looks good. /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.cpp <http://reviewboard.kde.org/r/2213/#comment2543> i think at this point i'd deleteLater() the applet icon and remove it from the model. this will prevent having to wait for sycoca to do its thing and react to it. - Aaron On 2009-11-20 13:51:32, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2213/ > ----------------------------------------------------------- > > (Updated 2009-11-20 13:51:32) > > > Review request for Plasma. > > > Summary > ------- > > Mostly copy/paste code. > TODO: > * How to hide widget explorer when about pressed? > * Buttons seem to take space in layout even when hidden, so removing/adding > now > * Some layout issues on first show > * list must be updated on uninstall/stop > * recycle about dialog (todo from old add widgets dialog) > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/appletslist.cpp > 1051785 > > /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.h > 1051785 > > /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/applettooltip.cpp > 1051785 > > /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.h > 1051785 > > /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsExplorer/widgetexplorer.cpp > 1051785 > > Diff: http://reviewboard.kde.org/r/2213/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
