----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/#review3063 -----------------------------------------------------------
trunk/KDE/kdelibs/plasma/abstractrunner.h <http://reviewboard.kde.org/r/2090/#comment2487> this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the need to explain how it works in the apidox :) trunk/KDE/kdelibs/plasma/runnercontext.h <http://reviewboard.kde.org/r/2090/#comment2488> sounds like something that should take a bool? also, some extra ws snuck in there :) trunk/KDE/kdelibs/plasma/runnermanager.h <http://reviewboard.kde.org/r/2090/#comment2489> const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if RunnerContext::singleRunnerMode() then replaceEmptyQuery should be implied? - Aaron On 2009-11-07 20:16:02, Jacopo De Simoi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2090/ > ----------------------------------------------------------- > > (Updated 2009-11-07 20:16:02) > > > Review request for Plasma, Aaron Seigo and Ryan Bitanga. > > > Summary > ------- > > This is the API needed by the new single Runner mode for krunner (more on > usecases in part II:krunner) for kdelibs; > > A runner can now optionally define a Default syntax; if this is the case, the > runner will be exposed as single-runner-mode capable. > On request, the default syntax will be replaced to the empty query in > RunnerManager::launchQuery. > > The context is aware of the fact that we are in single runner query mode in > case the runners need to change their behaviour accordingly (e.g. to _not_ > discard queries with less than 3 chars) > > > Diffs > ----- > > trunk/KDE/kdelibs/plasma/abstractrunner.h 1045930 > trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1045930 > trunk/KDE/kdelibs/plasma/runnercontext.h 1045930 > trunk/KDE/kdelibs/plasma/runnercontext.cpp 1045930 > trunk/KDE/kdelibs/plasma/runnermanager.h 1045930 > trunk/KDE/kdelibs/plasma/runnermanager.cpp 1045930 > > Diff: http://reviewboard.kde.org/r/2090/diff > > > Testing > ------- > > > Thanks, > > Jacopo > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
