----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2032/#review2893 -----------------------------------------------------------
Ship it! apart some minor issues i think it's fine /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp <http://reviewboard.kde.org/r/2032/#comment2302> perhaps reply() is enough /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp <http://reviewboard.kde.org/r/2032/#comment2303> retweet is a twitter specific word, perhaps postAgain() /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp <http://reviewboard.kde.org/r/2032/#comment2304> we will probably need icons for that, for now it's ok this way, i'll do them in the microblog svg later /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp <http://reviewboard.kde.org/r/2032/#comment2305> everything in the tweetframe should become a single Anchorlayout. eventually after commit too - Marco On 2009-10-31 15:15:29, Nicolas Réau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2032/ > ----------------------------------------------------------- > > (Updated 2009-10-31 15:15:29) > > > Review request for Plasma. > > > Summary > ------- > > I followed what i think is the most common behavior on Twitter/Identica which > is to reply to someone by writing @<hisname> at the beginning of your reply. > For the retweet I adopted this: RT: @<hisname> <hismessage> > > There is a wish report on b.k.o asking for this same behavior. However this > can be discussed, as I don't know if it's admitted as being the good behavior. > > > This addresses bug https://bugs.kde.org/show_bug.cgi?id=177906. > > https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=177906 > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.h 1042899 > /trunk/KDE/kdeplasma-addons/applets/microblog/microblog.cpp 1042899 > > Diff: http://reviewboard.kde.org/r/2032/diff > > > Testing > ------- > > Clicking the "@" button give the focus and scroll up to textedit box, with > @<username> written in it, and cursor at the end > Clicking the "RT" button give the focus and scroll up to textedit box, with > RT: @<username> <status> written in it, and cursor at the beginning > The 2 buttons are not shown inside your own tweets/dents > > > Screenshots > ----------- > > Reply and retweet buttons > http://reviewboard.kde.org/r/2032/s/244/ > > > Thanks, > > Nicolas > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
