----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1939/#review2785 -----------------------------------------------------------
Ship it! looks good. - Aaron On 2009-10-23 11:09:21, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1939/ > ----------------------------------------------------------- > > (Updated 2009-10-23 11:09:21) > > > Review request for Plasma. > > > Summary > ------- > > * Add support to load PopupApplet and Containment from path > * AppletScript::addStandardConfigurationPages adds also publish page > * AppletScript::standardConfigurationDialog does not add standard pages (or > what is addStandardConfigurationPages for?) > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/applet.cpp 1039407 > /trunk/KDE/kdelibs/plasma/containment.h 1039407 > /trunk/KDE/kdelibs/plasma/containment.cpp 1039407 > /trunk/KDE/kdelibs/plasma/popupapplet.h 1039407 > /trunk/KDE/kdelibs/plasma/popupapplet.cpp 1039407 > /trunk/KDE/kdelibs/plasma/private/applet_p.h 1039407 > /trunk/KDE/kdelibs/plasma/scripting/appletscript.cpp 1039407 > > Diff: http://reviewboard.kde.org/r/1939/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel