-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1877/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

As discussed on the plasma mailing list.  The Digital Clock applet has problems 
with l10n and i18n when formatting the date to be displayed, this change fixes 
these problems and simplifies the config while allowing more options.

The config GUI has changed from 3 tick-boxes to a single combobox of valid 
formats, which now includes the system locale formats.  Existing config files 
are automatically converted to the new config format.

Comment welcomed on available formats and wording in combobox


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 
1035179 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 
1035364 
  
trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 
1035179 

Diff: http://reviewboard.kde.org/r/1877/diff


Testing
-------

Tested conversion process for existing configs and new configs.  Tested 
selecting all available formats in gui.


Screenshots
-----------

Modified config gui
  http://reviewboard.kde.org/r/1877/s/230/
Date format combo
  http://reviewboard.kde.org/r/1877/s/231/


Thanks,

John

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to