> On 2009-10-16 16:07:51, Aaron Seigo wrote: > > why are there data members not in a dptr in an exported class?
you're right, i didn't think about it. i'll create a FadeAnimationPrivate > On 2009-10-16 16:07:51, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/animations/fade.cpp, line 47 > > <http://reviewboard.kde.org/r/1860/diff/1/?file=12773#file12773line47> > > > > if there was a previous call to setWidget, should the old > > m_opacityEffect be deleted first? yes, maybe this is needed because an user of this api would have the effect applied to his widget without knowing why - Giulio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1860/#review2666 ----------------------------------------------------------- On 2009-10-16 09:49:51, Giulio Camuffo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1860/ > ----------------------------------------------------------- > > (Updated 2009-10-16 09:49:51) > > > Review request for Plasma and Adenilson Cavalcanti. > > > Summary > ------- > > This little patch makes the FadeAnimation use QGraphicsOpacityEffect instead > of setting the opacity directly on the widget. > This solves a graphical glitch with Plasma::Label. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/animations/fade.h 1036002 > /trunk/KDE/kdelibs/plasma/animations/fade.cpp 1036002 > > Diff: http://reviewboard.kde.org/r/1860/diff > > > Testing > ------- > > tested, works > > > Thanks, > > Giulio > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
