----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1840/#review2634 -----------------------------------------------------------
i like the approach; the Animator::registerScrollingManager(QGraphicsWidget *) issue could be solved easily by making it Animator::registerScrollingManager(QGraphicsWidget *, bool) /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp <http://reviewboard.kde.org/r/1840/#comment1957> should be ok to pass in a null pointer for parent, so an if (d->parent) check here would probably be in order - Aaron On 2009-10-13 13:18:37, Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1840/ > ----------------------------------------------------------- > > (Updated 2009-10-13 13:18:37) > > > Review request for Plasma. > > > Summary > ------- > > this is just an experiment that has perhaps a too big disadvantage to be > practical... > makes use of event filters instead of explicitly forwarding mouse events. > the advantage is that it would be super easy to use and woouldn't be needed > to export new classes in plasma, there could just be an > Animator::registerScrollingManager(QGraphicsWidget *) function > > the big disadvantage is that is less controllable, so widgets can't decide to > -not- make use of the kineticscrolling, thing that is quite needed in WebView. > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/private/kineticscroll.cpp 1034755 > /trunk/KDE/kdelibs/plasma/private/kineticscroll_p.h 1034755 > /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.h 1034432 > /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1034699 > /trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1034432 > > Diff: http://reviewboard.kde.org/r/1840/diff > > > Testing > ------- > > > Thanks, > > Marco > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
