-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1760/
-----------------------------------------------------------
(Updated 2009-10-04 00:09:12.849772)
Review request for Plasma.
Changes
-------
gave it a copy ctor n'stuff, took away the raw qstring trigger and added some
convenience functions.
containment.cpp is still accessing privates; do you think it'd be better to
move that block of code into the config class? it'd need access to
containment's privates then, though; either way someone has to have access to
the internals of both classes.
Summary (updated)
-------
this creates a framework for shells to configure the set of default
ContainmentActions plugins for each type of containment (desktop, panel, etc).
the patch to kdebase is small so instead of creating a separate review request
I'll paste the important bit here:
@@ -51,6 +52,17 @@ void DesktopCorona::init()
Kephal::Screens *screens = Kephal::Screens::self();
connect(screens, SIGNAL(screenAdded(Kephal::Screen *)),
SLOT(screenAdded(Kephal::Screen *)));
connect(KWindowSystem::self(), SIGNAL(workAreaChanged()), this,
SIGNAL(availableScreenRegionChanged()));
+
+ Plasma::ContainmentActionsPluginsConfig desktopPlugins;
+ desktopPlugins.addPlugin(Qt::NoModifier, Qt::Vertical, "switchdesktop");
+ desktopPlugins.addPlugin(Qt::NoModifier, Qt::MidButton, "paste");
+ desktopPlugins.addPlugin(Qt::NoModifier, Qt::RightButton, "contextmenu");
+ Plasma::ContainmentActionsPluginsConfig panelPlugins;
+ panelPlugins.addPlugin(Qt::NoModifier, Qt::RightButton, "contextmenu");
+
+ setContainmentActionsDefaults(Plasma::Containment::DesktopContainment,
desktopPlugins);
+ setContainmentActionsDefaults(Plasma::Containment::PanelContainment,
panelPlugins);
+ setContainmentActionsDefaults(Plasma::Containment::CustomPanelContainment,
panelPlugins);
}
Diffs (updated)
-----
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/dev/null PRE-CREATION
/trunk/KDE/kdelibs/plasma/CMakeLists.txt 1029909
/trunk/KDE/kdelibs/plasma/containment.cpp 1029909
/trunk/KDE/kdelibs/plasma/corona.h 1029909
/trunk/KDE/kdelibs/plasma/corona.cpp 1029909
Diff: http://reviewboard.kde.org/r/1760/diff
Testing
-------
Thanks,
Chani
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
