> On 2009-09-24 10:40:54, Marco Martin wrote: > > have you teste what happens when the associated widget is actually 0?
What should I test here? The documentation does not state the expected behaviour when passing a 0 or non-widget parent. The patch only ensures that KWindowSystem is not called with a non-toplevel widget, the remaining behaviour is unchanged. - Christoph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1707/#review2457 ----------------------------------------------------------- On 2009-09-24 03:20:31, Christoph Feck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1707/ > ----------------------------------------------------------- > > (Updated 2009-09-24 03:20:31) > > > Review request for kdelibs and Plasma. > > > Summary > ------- > > Use the window() of the passed parent() as the associated widget to avoid > creating a native widget for the child due to all the winId() calls. Alien > widgets are much faster. > > > Diffs > ----- > > /trunk/KDE/kdelibs/kdeui/notifications/knotificationitem.cpp 1027406 > > Diff: http://reviewboard.kde.org/r/1707/diff > > > Testing > ------- > > > Thanks, > > Christoph > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
