----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1706/#review2451 -----------------------------------------------------------
part of the patch did not apply cleanly to trunk. can you check that? other than that, a few small issues but nothing outstanding. looking forward to this being in svn for 4.4 :) trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/CMakeLists.txt <http://reviewboard.kde.org/r/1706/#comment1792> not needed :) trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h <http://reviewboard.kde.org/r/1706/#comment1793> QColor color() const; should be enough? trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp <http://reviewboard.kde.org/r/1706/#comment1794> usually we just do: cg.readEntry("Size", 4); trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp <http://reviewboard.kde.org/r/1706/#comment1796> m_fifteen->size() must be guaranteed to never return 0. worth checking that over or else changing these to qMax(4, m_fifteen->size()); for safety's sake. trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp <http://reviewboard.kde.org/r/1706/#comment1795> void Piece::shuffling() { (curly brace on its own line) - Aaron On 2009-09-24 00:56:28, Tomaz Canabrava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1706/ > ----------------------------------------------------------- > > (Updated 2009-09-24 00:56:28) > > > Review request for Plasma. > > > Summary > ------- > > colors are now configurable, > and number of pieces too. > everything is saved and restored. > shuffle now also shows a bit of movement while shuffling. > > > Diffs > ----- > > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/CMakeLists.txt 1026834 > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/images/blanksquare.svgz > UNKNOWN > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/images/greensquare.svgz > UNKNOWN > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.h 1026834 > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteen.cpp 1026834 > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzle.cpp > 1026834 > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.h > 1026834 > > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.cpp > 1026834 > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/fifteenPuzzleConfig.ui > 1026834 > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.h 1026834 > trunk/KDE/kdeplasma-addons/applets/fifteenPuzzle/src/piece.cpp 1026834 > > Diff: http://reviewboard.kde.org/r/1706/diff > > > Testing > ------- > > everything looks ok. > > > Thanks, > > Tomaz > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
