> On 2009-09-23 22:01:11, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/containment.cpp, line 1839 > > <http://reviewboard.kde.org/r/1699/diff/1/?file=11890#file11890line1839> > > > > is the name given now by the desktop settings dialog going to be an > > identifier rather than a name? > > seems qute a behavioural change for this function
Yes, there is a behavioural change - mostly because the activity names are not unique (empty by default) which is the reason everything is done by IDs. I agree that changing the behaviour is a bad thing, but almost nobody used these classes (there wasn't that much to be used - they were mostly empty) > On 2009-09-23 22:01:11, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/private/activitieshandler.h, line 76 > > <http://reviewboard.kde.org/r/1699/diff/1/?file=11893#file11893line76> > > > > maybe should be done with a bool activityExists() > > function+createactivity? > > > > but this shortcut could be handy anyways, hmm... > > a check function would make sense anyways tough > > ok about the check function. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1699/#review2439 ----------------------------------------------------------- On 2009-09-23 20:19:36, Ivan Cukic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1699/ > ----------------------------------------------------------- > > (Updated 2009-09-23 20:19:36) > > > Review request for Plasma. > > > Summary > ------- > > Nepomuk-based storage of plasma activities > > > Diffs > ----- > > /trunk/KDE/kdelibs/plasma/CMakeLists.txt 1027137 > /trunk/KDE/kdelibs/plasma/applet.cpp 1027137 > /trunk/KDE/kdelibs/plasma/containment.h 1027137 > /trunk/KDE/kdelibs/plasma/containment.cpp 1027137 > /trunk/KDE/kdelibs/plasma/context.h 1027137 > /trunk/KDE/kdelibs/plasma/context.cpp 1027137 > /trunk/KDE/kdelibs/plasma/private/activitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/activitieshandler.cpp PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/context_p.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 1027137 > /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/fallbackactivitieshandler.cpp > PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.h PRE-CREATION > /trunk/KDE/kdelibs/plasma/private/nepomukactivitieshandler.cpp PRE-CREATION > > Diff: http://reviewboard.kde.org/r/1699/diff > > > Testing > ------- > > Needs more testing > > > Thanks, > > Ivan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
