----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1655/#review2414 -----------------------------------------------------------
As you say, these changes are incomplete. The way that quitting is handled (whether to quit or not, depending on which windows are open) is a very important feature in KAlarm, and looking at the patch, I'm not convinced that it handles this properly. I don't have time currently to look at this in detail, but please don't commit yet until everything has been fixed and tested. /trunk/KDE/kdepim/kalarm/kalarmapp.cpp <http://reviewboard.kde.org/r/1655/#comment1713> This line shouldn't be removed unless there's some alternative mechanism for showing the window. - David On 2009-09-19 21:43:30, Davide Bettio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1655/ > ----------------------------------------------------------- > > (Updated 2009-09-19 21:43:30) > > > Review request for KDE PIM and Plasma. > > > Summary > ------- > > I've attempted to port KAlarm to KNotificationItem. > I don't know how to port some pieces of code. > Probably I will post a new patch soon. > > > Diffs > ----- > > /trunk/KDE/kdepim/kalarm/kalarmapp.h 1024122 > /trunk/KDE/kdepim/kalarm/kalarmapp.cpp 1024122 > /trunk/KDE/kdepim/kalarm/mainwindow.cpp 1024122 > /trunk/KDE/kdepim/kalarm/traywindow.h 1024122 > /trunk/KDE/kdepim/kalarm/traywindow.cpp 1024122 > > Diff: http://reviewboard.kde.org/r/1655/diff > > > Testing > ------- > > > Thanks, > > Davide > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
