> On 2009-08-02 23:51:37, Aaron Seigo wrote: > > looks fine; perhaps all the instances of -1 should be replaced with a > > `static const int UNLIMITED_ICONS = -1` in the header file? :) > > Shafqat Bhuiyan wrote: > Ok I added the UNLIMITED_ICONS = -1 :) > > PS. Could you please commit this because my SVN account still isn't > working :S > > Aaron Seigo wrote: > hm.. i thought i saw the update to your account the other day? there's no > rush on these fixes at this point (4.3.0 is already tagged, so this will end > up in 4.3.1 and 4.4 only), maybe you could find out what's up with your svn > account? find one of us on irc maybe and we can try and figure out what's > up... > > Beat Wolf wrote: > is there any news on the svn account or the patch?
I got my svn account sorted and it seems to work fine now :) I still have the patch on my machine and I'll commit it once I figure it how to backport patches. Any hints are welcome... ;) - Shafqat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/#review1885 ----------------------------------------------------------- On 2009-08-03 00:17:24, Shafqat Bhuiyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1220/ > ----------------------------------------------------------- > > (Updated 2009-08-03 00:17:24) > > > Review request for Plasma. > > > Summary > ------- > > This patch fixes a couple of bugs when having unlimited visible icons in the > quicklaunch plasmoid. > They were: > > - Having a vertical panel with unlimited number of icons resulted in just one > row of squashed icons > > - Having unlimited icons gives a bigger width for no reason > > This should be backported to 4.3 > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp > 1004927 > > Diff: http://reviewboard.kde.org/r/1220/diff > > > Testing > ------- > > tested and compiled on trunk > > > Thanks, > > Shafqat > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
