> On 2009-08-29 21:00:29, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp, > > line 204 > > <http://reviewboard.kde.org/r/1370/diff/4/?file=10494#file10494line204> > > > > We probably need to change this; > > Either show every time %i actions for this device and show the action > > items in this case as well, > > or make the action items appear only if there are more than 1 action. > > I would strongly suggest the second solution
I know it. It is simply unuseful to show the action when you already know what it is, but it was far in my priorities list :) > On 2009-08-29 21:00:29, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp, > > line 183 > > <http://reviewboard.kde.org/r/1370/diff/4/?file=10498#file10498line183> > > > > I am confused about what you mean by column and row.. they seem > > reversed to me you're right, it is a bit ambiguous, maybe it had to be layActionsIn*One*Column. > On 2009-08-29 21:00:29, Jacopo De Simoi wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp, > > line 219 > > <http://reviewboard.kde.org/r/1370/diff/4/?file=10498#file10498line219> > > > > Also, this will need to be changed when we will handle correctly > > AudioCD and BlankCD, which cannot be mounted but can be ejected, We'll take > > care of it once committed well, I really don't know why, but here on my 4.3 with the applet from kde-look, when I insert an AudioCD there's no button at all. - Giulio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2179 ----------------------------------------------------------- On 2009-08-21 19:26:43, Giulio Camuffo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1370/ > ----------------------------------------------------------- > > (Updated 2009-08-21 19:26:43) > > > Review request for Plasma. > > > Summary > ------- > > This is a patch that modifies quite heavily the behaviour of the Device > Notifier. > It comes from here: > http://kde-look.org/content/show.php/Device+Manager?content=106051 > It can show the not removable devices too, it can mount them automatically or > with a click, since the "eject" button is a "mount" button when the volume is > umounted. So that guy on the dot will be ok. > It can hide some items in the same way as Dolphin's places (hide item/ show > all). > Finally, it shows the various opening actions under the device instead of > calling that xp-ish window. > > > Diffs > ----- > > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui > PRE-CREATION > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp > 1013960 > > Diff: http://reviewboard.kde.org/r/1370/diff > > > Testing > ------- > > I'm using it every day since I released 0.1 on Kde-look. I tried all the > options on my pc and they work. Some people on kde-look posted some comments > about some problems, but it seems to me they are very particular cases, so in > my opinion it is quite stable to go in trunk, but anyway review it! :) > > > Screenshots > ----------- > > screen > http://reviewboard.kde.org/r/1370/s/183/ > > > Thanks, > > Giulio > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
