潘卫平(Peter Pan) 写道: > Lukas Appelhans 写道: >> Am Freitag 14 August 2009 15:11:51 schrieb 潘卫平(Peter Pan): >>> Lukas Appelhans 写道: >>>> Am Freitag 14 August 2009 14:00:40 schrieb 潘卫平(Peter Pan): >>>>> Lukas Appelhans 写道: >>>>>> Am Freitag 14 August 2009 11:10:42 schrieb 潘卫平(Peter Pan): >>>>>>> Hi,all >>>>>>> >>>>>>> I think we should give user a hint when he/she adds a application >>>>>>> which already exists in quicklaunch, so I made this patch. >>>>>>> >>>>>>> >>>>>>> Regards >>>>>> Hey! >>>>>> >>>>>> Good thing! But 2 things: I'm not 100% into the code currently, but why >>>>>> not implementing the loop inside addProgram()? >>>>> In the beginning, I want to quit as soon as possible, to save CPU >>>>> cycles. But I agree that addProgram() is a more elegant place, but we >>>>> should pay attention to initializing and sorting. >>>>> >>>>>> And the second one: "Cancel or Continue?" is not needed as words inside >>>>>> the MessageBox imo, as the buttons are named like it... "\"%1\" is >>>>>> already in quicklaunch!" should be enough! >>>>> agree with you. >>>>> And I modify my patch. >>>> Ok that looks much nicer... :) Now I think we can merge m_isSorting and >>>> m_isInitializing to m_isBusy or m_notAdding or sth like this... >>> done. I use m_isBusy. Thanks a lot. >> That looks nice to me! Thanks for your patch! If you have an SVN-Account you >> can commit it, else I will do it :) >> > Let me do it my self. > Many thanks.
svn r 1011382 >> Lukas >>>> Lukas >>>> >>>>>> Regards, >>>>>> >>>>>> Lukas >>>>>> _______________________________________________ >>>>>> Plasma-devel mailing list >>>>>> Plasma-devel@kde.org >>>>>> https://mail.kde.org/mailman/listinfo/plasma-devel >>>> _______________________________________________ >>>> Plasma-devel mailing list >>>> Plasma-devel@kde.org >>>> https://mail.kde.org/mailman/listinfo/plasma-devel >>> Regards >> _______________________________________________ >> Plasma-devel mailing list >> Plasma-devel@kde.org >> https://mail.kde.org/mailman/listinfo/plasma-devel > > Regards Reards -- 潘卫平(Peter Pan) Red Flag Software Co., Ltd _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
