> On 2009-08-10 12:00:23, Artur de Souza (MoRpHeUz) wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, > > line 54 > > <http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line54> > > > > maybe you get the error post icon even after a successful post because > > it tries to retrieve more data and then you fall in this place. not sure > > though and right now I don't have the time to test. Check form where > > postError() is being emited on your backend code. (probably from here)
Thanks for the hint, I'll test it with qDebug(). ;-) > On 2009-08-10 12:00:23, Artur de Souza (MoRpHeUz) wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui, line > > 57 > > <http://reviewboard.kde.org/r/1251/diff/1/?file=9806#file9806line57> > > > > With more plugins being added we need to properly fix this config tab > > now. We postponed this as much as we could but now we should do it > > properly. I'll come with something later (plane to tokamak? hehe). Yes, this should be done cleaner, maybe it is possible to create kind of service for backends and use them through data engine, as mentioned earlier? - Michal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1950 ----------------------------------------------------------- On 2009-08-09 21:08:23, Michal Dutkiewicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1251/ > ----------------------------------------------------------- > > (Updated 2009-08-09 21:08:23) > > > Review request for Plasma. > > > Summary > ------- > > This patch adds support for Simplest Image Hosting > (http://simplest-image-hosting.net/) to pastebin applet. > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h > PRE-CREATION > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp > PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui > 1008396 > > Diff: http://reviewboard.kde.org/r/1251/diff > > > Testing > ------- > > Works fine except showing error icon even if upload is successful (there is > success notification and link is added to history). > > > Thanks, > > Michal > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
