On Thursday 06 August 2009, 潘卫平(Peter Pan) wrote: > In KDE 3 , it was possible to set a wallpaper by dragging a picture from > konqueror. And I implement this feature in Plasma::Containment.
i don't think this is really the right place for this code (in Containment); rather, i think this would be better implemented as an extension to Chani's containment actions project. not all libplasma based applications will want to have images dropped on them setting the background, so this is really something that needs to be done per- application. being able to define the default actions for dropped data therefore seems to make more sense. also, just as an implementation note: + if (suffix == "png" || suffix == "jpg" || suffix == "jpeg" || suffix == "xcf" + || suffix == "svg" || suffix == "svgz") it would probably be better to do a KMimeType based check :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel