On Tuesday 21 July 2009, 潘卫平(Peter Pan) wrote: > Do you mean that I should use Plasma::BusyWidget ?
yes
> I made a patch using Plasma::BusyWidget, It looks fine.
i wonder if it wouldn't make more sense to show it in place of the icon
instead of right over the text?
also, you don't need to check a variable before deleting it, e.g. this:
+ if (m_busyWidget) {
+ delete m_busyWidget;
+ }
should just be this:
delete m_busyWidget;
m_busyWidget = 0;
that last check is important because the value of m_busyWidget is checked
elsewhere in the code! right now it won't crash because we only use a task
once for a startup item, but if that ever changes just deleting the object but
not resetting the pointer would lead to a crash.
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
