----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1099/ -----------------------------------------------------------
Review request for Plasma. Summary ------- The patch fix/workaround this bug https://bugs.kde.org/show_bug.cgi?id=200981 . I've added a new slot called existingContainmentAdded in plasmapp.cpp, is almost like containmentAdded slot but the new one doesn't add the actions. Then, I've had to create a new signal in corona (kdelibs) desired to be emmited when an already existing containment is added. And finally, I replaced containmentAdded signal by the new one in desktopcorona.cpp. I feel the need of add a new slot because containmentAdded (slot) is used in more than one place, so add an argument is not an option. Also, I took a look at containment class and containmentPrivate, but I haven't found a good place to add anything that could fix this situation. Diffs ----- trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1000737 trunk/KDE/kdebase/workspace/plasma/shells/desktop/desktopcorona.cpp 1000737 trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.h 1000737 trunk/KDE/kdebase/workspace/plasma/shells/desktop/plasmaapp.cpp 1000737 trunk/KDE/kdelibs/plasma/corona.h 1000737 Diff: http://reviewboard.kde.org/r/1099/diff Testing ------- I test this patch using 1 and 2 monitors with a few different configurations, everything works well and the actions are never duplicated. Thanks, Alex _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
