Hey, I'll be off for 3 days. Going back home. Will join from there. On 7/11/09, Shantanu Tushar Jha <jhahon...@gmail.com> wrote: > On Sat, Jul 11, 2009 at 2:06 PM, Yuen Hoe Lim <yuenho...@gmail.com> wrote: > >> Hi Shantanu, >> >> I've commited modifications so that we use KMenu instead of the >> overlay when the previewer is small. 'Small' is decided by a static >> height limit - not very intelligent but should do for now :) > > > Right now, I think it should apply to width also. Rest seems all fine to > me. > > >> >> Try it out and see what you think :) >> >> On 7/11/09, Shantanu Tushar Jha <jhahon...@gmail.com> wrote: >> > On Sat, Jul 11, 2009 at 11:56 AM, Yuen Hoe Lim <yuenho...@gmail.com> >> wrote: >> > >> >> Hi Shantanu, >> >> >> >> I got that one more or less sorted out already, and am now thinking >> >> about what's the best way to arrange the code before committing :P On >> >> that topic, now that I've actually tried out using a KMenu, I actually >> >> like it better than the overlay - it's keyboard accessible and the >> >> overlay has visibility problems with certain backgrounds. I'd actually >> >> be quite happy if we just used a KMenu all the way :P What do you >> >> think? >> > >> > Well, I kind of like the Overlay, but it is a personal opinion, so I >> think >> > we gather others' opinion on this. Maybe on #plasma. >> > Even I was trying how to use a KMenu right now, but as you've already >> done >> > it, I'm eager to see it in action :) >> > >> >> >> >> >> >> For now I'm implementing what we discussed - use KMenu only when it's >> >> small. I'll try getting my stuff committed by the end of today. In the >> >> meantime maybe you could help me take a look at my refresh applet >> >> code? At least for me, the applet always ends up being a little >> >> smaller post-refresh, and I'm not sure how to fix that :P >> > >> > >> > Let me check it out. >> > >> >> >> >> >> >> Will get on #plasma in case you'd like to talk. >> > >> > Yep, I'm there right now, come if you can :) >> > >> > >> >> >> >> >> >> On 7/11/09, Shantanu Tushar Jha <jhahon...@gmail.com> wrote: >> >> > Hi, so my exams are finished now. Yuen has sorted out most of the >> >> > things >> >> we >> >> > discussed. Now, I think next we should fix the previewer_being_small >> >> > problem. >> >> > As far as I remember, we can provide a menu whenever the previewer >> >> > is >> >> > too >> >> > small for the overlay to be displayed correctly (not removing the >> >> > overlay >> >> > completely). >> >> > I'm taking a look how to implement using a KMenu, just wanted to >> >> > know >> >> > if >> >> > you're doing something already, Yuen? >> >> > >> >> > -- >> >> > Shantanu Tushar (UTC +0530) >> >> > http://www.shantanutushar.com >> >> > >> >> >> >> >> >> -- >> >> ---- >> >> Jason "moofang" Lim Yuen Hoe >> >> http://yuenhoe.co.cc/ >> >> >> > >> > >> > >> > -- >> > Shantanu Tushar (UTC +0530) >> > http://www.shantanutushar.com >> > >> >> >> -- >> ---- >> Jason "moofang" Lim Yuen Hoe >> http://yuenhoe.co.cc/ >> > > > > -- > Shantanu Tushar (UTC +0530) > http://www.shantanutushar.com >
-- Sent from Gmail for mobile | mobile.google.com Shantanu Tushar (UTC +0530) http://www.shantanutushar.com _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
